Implement schema methods in the HttpManagementProxy (fixes #1344) #1366
Conversation
|
No linked issues found. Please add the corresponding issues in the pull request description. |
olim7t
force-pushed
the
feature/schema-methods
branch
from
2004098
to
ecd45cd
Compare
olim7t
force-pushed
the
feature/schema-methods
branch
from
ecd45cd
to
bfe4a55
Compare
| @@ -159,12 +161,27 @@ public String getClusterName() { | |||
|
|
|||
| @Override | |||
| public List<String> getKeyspaces() { | |||
There was a problem hiding this comment.
Issue: Can we please have a unit test for this method? Maybe something that mocks apiClient.listKeyspaces() and then just confirms that it was called?
There was a problem hiding this comment.
@Miles-Garnsey , is this a todo: or a suggestion: ?
There was a problem hiding this comment.
Sorry, an issue I think.
| } catch (ApiException ae) { | ||
| LOG.error("Failed to list keyspaces", ae); | ||
| return Collections.emptyList(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Set<Table> getTablesForKeyspace(String keyspace) throws ReaperException { |
There was a problem hiding this comment.
Issue: Would be good to see a unit test for this too please :) Similar procedure to the other one, mock the call to the apiClient method and confirm that the processing in the rest of the method does what it should.
There was a problem hiding this comment.
I added both unit tests as requested.
|
I am merging this because all tests are green, it is approved, and I want the |
Miles-Garnsey
merged commit cd9898a
into
thelastpickle:integration/http-managementproxy
Fixes #1344
Prerequisites:
datastax-mgmtapi-client-openapiversion insrc/server/pom.xml.