Implement getPartitioner() in HttpManagementProxy #1394
Conversation
|
@adejanovski this looks like it is failing to even build, is it draft? |
Sorry, it's a checkstyle issue that I missed. |
adejanovski
force-pushed
the
get-partitioner-http
branch
2 times, most recently
from
25687f0
to
efabcef
Compare
adejanovski
force-pushed
the
get-partitioner-http
branch
from
efabcef
to
fea52ad
Compare
adejanovski
force-pushed
the
get-partitioner-http
branch
from
fea52ad
to
f50c6c8
Compare
| @@ -367,7 +367,7 @@ public Map<String, String> getEndpointToHostId() { | |||
| } | |||
|
|
|||
| @Override | |||
| public String getPartitioner() { | |||
| public String getPartitioner() throws ReaperException { | |||
| Preconditions.checkNotNull(ssProxy, "Looks like the proxy is not connected"); | |||
There was a problem hiding this comment.
Question: Should this throw an exception now if the proxy is not connected?
There was a problem hiding this comment.
No, since the StorageServiceMbean.getPartitionerName() signature doesn't throw anything, we can't properly get the errors.
I'll wrap this in a try/catch block for RuntimeExceptions and wrap it in a ReaperException.
There was a problem hiding this comment.
Sounds good. I'll approve now and you can merge once you've made this change and all checks are passing.
...erver/src/test/java/io/cassandrareaper/management/http/HttpCassandraManagementProxyTest.java
Show resolved
Hide resolved
...erver/src/test/java/io/cassandrareaper/management/http/HttpCassandraManagementProxyTest.java
Show resolved
Hide resolved
adejanovski
merged commit 11676e4
into
integration/http-managementproxy
fixes #1381