Add instance caching to HttpManagementConnectionFactory #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for each connectImpl call
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Miles-Garnsey
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
My testing suggests that this doesn't break any additional tests (beyond the acceptance tests already broken) and it helps make debugging much easier because fewer HTTP proxies are created.
It'll probably also reduce GC pressure due to cleaning up those proxies I guess.
Nice work!
Miles-Garnsey
merged commit 48bdb4a
into
integration/http-managementproxy
19 of 21 checks passed
Miles-Garnsey
pushed a commit
that referenced
this pull request
Oct 3, 2023
…e for each connectImpl call (#1413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e for each connectImpl call
Fixes #1414