Arm64 images #1418
Merged
Arm64 images #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
force-pushed
the
arm64-images
branch
from
a4c1fcd
to
8a45a15
Compare
emerkle826
approved these changes
Sep 29, 2023
.github/workflows/ci.yaml
Outdated
| @@ -364,15 +364,15 @@ jobs: | |||
| run: | | |||
| pip install pyyaml | |||
| pip install ccm | |||
|
|
|||
There was a problem hiding this comment.
nit:
would be nice to not have these single space character additions as changes.
There was a problem hiding this comment.
definitely, sorry about that
.github/workflows/ci.yaml
Outdated
| @@ -457,7 +457,7 @@ jobs: | |||
| - name: Compute version number | |||
| run: | | |||
| VERSION=$(printf 'VER\t${project.version}' | mvn help:evaluate | grep '^VER' | cut -f2) | |||
| if [ "${GITHUB_REF}" = "refs/heads/master" ] | |||
| if [ "${GITHUB_REF}" = "refs/heads/arm64-images" ] | |||
There was a problem hiding this comment.
question:
Shouldn't this be reverted to master once this PR is merged?
There was a problem hiding this comment.
good catch, let me change it before merging
adejanovski
force-pushed
the
arm64-images
branch
from
6a718dc
to
1b41172
Compare
adejanovski
force-pushed
the
arm64-images
branch
from
1b41172
to
ccd7400
Compare
adejanovski
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1407
Multi-arch Images built with this PR can be seen on Docker Hub.