Fix JmxConnectionFactory.connectAny(..) to loop a second time trying all hosts regardless of past successes/failures #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsembwever
force-pushed
the
mck/fix-JmxConnectionFactory-connectAny-second-loop
branch
from
26a8235
to
cf4e1b8
Compare
michaelsembwever
added a commit
that referenced
this pull request
Oct 18, 2017
…all hosts regardless of past successes/failures. ref: #239
|
|
||
| for (int i = 0; i < 2; i++) { | ||
| while (hostIterator.hasNext()) { |
There was a problem hiding this comment.
this iterator was not being "reset" for the second loop, so the second loop never did anything…
adejanovski
approved these changes
Oct 19, 2017
…all hosts regardless of past successes/failures. ref: #239
michaelsembwever
force-pushed
the
mck/fix-JmxConnectionFactory-connectAny-second-loop
branch
from
cf4e1b8
to
4663b86
Compare
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
| String host = hostIterator.next(); | ||
|
|
||
| for (String host : hostList) { | ||
| assert null != host; // @todo remove the null check in the following if condition |
There was a problem hiding this comment.
michaelsembwever
deleted the
mck/fix-JmxConnectionFactory-connectAny-second-loop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.