Cassandra Storage #3
Labels
Milestone
Comments
|
Is this now done? I see that #2 is merged. |
|
Yes, it has been merged into master a few days ago. |
plastikat
added a commit
to plastikat/cassandra-reaper
that referenced
this issue
Apr 3, 2020
> This is a combination of 5 commits. > This is the 1st commit message: Enable errexit > This is the commit message thelastpickle#2: Refactor JAR search logic This adds to code reuse. > This is the commit message thelastpickle#3: A bit more concise CONFIG_PATH selection Not really useful, but avoids the unnecessary string literal duplication. > This is the commit message thelastpickle#4: Refine REAPER_JAR search Do not search from '/' to avoid log cluttering and save startup time. And anyway, searching from '/' kills the very idea of searching for a *user* JAR (as apposed to a system JAR) and also makes the search result less predictable (as *all* JARs will eventually be found). The main motivation was that systemd services start with '/' as the working directory, so the system log gets filled with errors on each service start. While b970844 fixes searching from '/' for systemd service, still an explicit check pursues additional goals. > This is the commit message thelastpickle#5: Add SSL/TLS support To support clusters that have their JMX protected with SSL/TLS encryption, let us allow to configure the respective Java parameters.
adejanovski
pushed a commit
that referenced
this issue
Apr 3, 2020
> This is a combination of 5 commits. > This is the 1st commit message: Enable errexit > This is the commit message #2: Refactor JAR search logic This adds to code reuse. > This is the commit message #3: A bit more concise CONFIG_PATH selection Not really useful, but avoids the unnecessary string literal duplication. > This is the commit message #4: Refine REAPER_JAR search Do not search from '/' to avoid log cluttering and save startup time. And anyway, searching from '/' kills the very idea of searching for a *user* JAR (as apposed to a system JAR) and also makes the search result less predictable (as *all* JARs will eventually be found). The main motivation was that systemd services start with '/' as the working directory, so the system log gets filled with errors on each service start. While b970844 fixes searching from '/' for systemd service, still an explicit check pursues additional goals. > This is the commit message #5: Add SSL/TLS support To support clusters that have their JMX protected with SSL/TLS encryption, let us allow to configure the respective Java parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
currently in PR #2
The text was updated successfully, but these errors were encountered: