New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new attributes and some aliases to the {cart} substitution #1725

Merged
merged 1 commit into from Nov 26, 2015

Conversation

Projects
None yet
3 participants
@roadster31
Contributor

roadster31 commented Oct 9, 2015

This PR is add attributes to the {cart} substitution

  1. A new weight attribute is added, to get the cart total weight.
  2. A new total_price_without_discount attribute is added, to get the cart total amount without taxes, excluding discount.
  3. The following aliases of existing attributes are added, to provide a better english syntax, or a more accurate name :
    • product_count, alias of count_product
    • item_count, alias of count_item
    • total_price_with_discount alias of total_price
    • total_taxed_price_with_discount alias of total_taxed_price
    • contains_virtual_product alias of is_virtual
    • total_tax_amount alias of total_vat

@roadster31 roadster31 changed the title from Added 'weight' attribute, and some aliases to the {cart} substitution to Added new attributes and some aliases to the {cart} substitution Oct 9, 2015

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Oct 13, 2015

Contributor

Can you just squash your commits and I will merge your PR.
Thanks.

Contributor

bibich commented Oct 13, 2015

Can you just squash your commits and I will merge your PR.
Thanks.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Oct 14, 2015

Contributor

Done !

There is a related PR in the Thelia doc : thelia/thelia.github.io#172

Contributor

roadster31 commented Oct 14, 2015

Done !

There is a related PR in the Thelia doc : thelia/thelia.github.io#172

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Oct 16, 2015

Contributor

Thanks

Contributor

bibich commented Oct 16, 2015

Thanks

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

gillesbourgeat added a commit that referenced this pull request Nov 26, 2015

Merge pull request #1725 from roadster31/cart-subst
Added new attributes and some aliases to the {cart} substitution

@gillesbourgeat gillesbourgeat merged commit 26f5fcc into thelia:master Nov 26, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:cart-subst branch Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment