New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase API key size to 48 #1769

Merged
merged 1 commit into from Nov 14, 2015

Conversation

Projects
None yet
3 participants
@jmaupetit
Contributor

jmaupetit commented Nov 8, 2015

An even length for hexadecimal strings increases compatibility with other languages (like python) that systematically refuse to convert odd hexadecimal strings to binary data. This could be blocking if someone tries to consume thelia's API.

Increase API key size
An even length for hexadecimal strings increase compatibility with other languages.
@lunika

This comment has been minimized.

Show comment
Hide comment
@lunika

lunika Nov 8, 2015

Contributor

👍 This PR doesn't break BC So it will be great to merge it in version 2.1 and 2.2 too.

Contributor

lunika commented Nov 8, 2015

👍 This PR doesn't break BC So it will be great to merge it in version 2.1 and 2.2 too.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 14, 2015

Member

Thanks !

Member

gillesbourgeat commented Nov 14, 2015

Thanks !

gillesbourgeat added a commit that referenced this pull request Nov 14, 2015

@gillesbourgeat gillesbourgeat merged commit 989c970 into thelia:master Nov 14, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

(related to #1769) Increase API key size to 48
An even length for hexadecimal strings increase compatibility with other languages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment