New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix product price exports #1783

Merged
merged 6 commits into from Nov 30, 2015

Conversation

Projects
None yet
2 participants
@ThomasArnaud
Contributor

ThomasArnaud commented Nov 19, 2015

Resolve #1078
Resolve #1610

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 19, 2015

Member

Hello,
You break the unit tests !

Member

gillesbourgeat commented Nov 19, 2015

Hello,
You break the unit tests !

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@gillesbourgeat gillesbourgeat added the bug label Nov 19, 2015

ThomasArnaud added some commits Nov 20, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 25, 2015

Member

Your PR does not solve the problem. If the product does not have a combination of attributes, it is not in the export.
I tested with the "Product prices excluding taxes" export

Member

gillesbourgeat commented Nov 25, 2015

Your PR does not solve the problem. If the product does not have a combination of attributes, it is not in the export.
I tested with the "Product prices excluding taxes" export

ThomasArnaud added some commits Nov 26, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 30, 2015

Member

Thanks !

Member

gillesbourgeat commented Nov 30, 2015

Thanks !

gillesbourgeat added a commit that referenced this pull request Nov 30, 2015

@gillesbourgeat gillesbourgeat merged commit 73bd404 into thelia:master Nov 30, 2015

2 checks passed

Scrutinizer 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment