fix product price exports #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasArnaud
force-pushed
the
product-price-export
branch
from
c49363b
to
5b52007
Compare
|
Hello, |
| @@ -128,12 +130,12 @@ public function getOrder() | |||
| "id", | |||
| "product_id", | |||
| "title", | |||
| "attributes", | |||
There was a problem hiding this comment.
Why did you move the output value "attributes" ?
|
Your PR does not solve the problem. If the product does not have a combination of attributes, it is not in the export. |
ThomasArnaud
force-pushed
the
product-price-export
branch
2 times, most recently
from
19c65f5
to
74ce23f
Compare
ThomasArnaud
force-pushed
the
product-price-export
branch
2 times, most recently
from
9835c93
to
1e6ce6a
Compare
|
Thanks ! |
gillesbourgeat
added a commit
that referenced
this pull request
Nov 30, 2015
fix product price exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1078
Resolve #1610