New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cart duplication conditions at user login/logout #1801

Merged
merged 3 commits into from Jan 7, 2016

Conversation

Projects
None yet
3 participants
@roadster31
Contributor

roadster31 commented Nov 26, 2015

This PR is a fix for #1798 : the cart should be duplicated when a user with a permanent discount is logging in.

The code for deciding if the current cart should be duplicated has been factorized and improved.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Jan 7, 2016

Contributor

This PR is complete.

Contributor

roadster31 commented Jan 7, 2016

This PR is complete.

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Jan 7, 2016

bibich added a commit that referenced this pull request Jan 7, 2016

Merge pull request #1801 from roadster31/cart-duplication-when-login-fix
Fixed cart duplication conditions at user login/logout

@bibich bibich merged commit 8252a07 into thelia:master Jan 7, 2016

2 checks passed

Scrutinizer 2 new issues, 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:cart-duplication-when-login-fix branch Jan 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment