New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposition] Add the possibility to disable the generation of url for the loops #1852

Merged
merged 2 commits into from Dec 22, 2015

Conversation

Projects
None yet
3 participants
@gillesbourgeat
Member

gillesbourgeat commented Dec 17, 2015

The loops returns an url although there are no need.
This PR adds argument return_url that can be used for disable the generation of urls.
The default value for argument return_url is true

@gillesbourgeat gillesbourgeat changed the title from Add the possibility to disable the generation of url for the loops to [proposition] Add the possibility to disable the generation of url for the loops Dec 17, 2015

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 17, 2015

Contributor

What is the goal of this PR ? Is there a perfomance problem with URL generation ?

Contributor

roadster31 commented Dec 17, 2015

What is the goal of this PR ? Is there a perfomance problem with URL generation ?

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 17, 2015

Member

Not with the generator, but with too many useless request.

Example for a site that has 300 brands, 200 categories.
The product edit page will make 500 useless request on rewriting table.

The product edit page will make 500 useless request on rewriting table.

If the rewrite table contains many url, the product edit page becomes very slow.

Other example for the FrontOffice with faceted search engine.

Other example for the FrontOffice with faceted search engine.

Member

gillesbourgeat commented Dec 17, 2015

Not with the generator, but with too many useless request.

Example for a site that has 300 brands, 200 categories.
The product edit page will make 500 useless request on rewriting table.

The product edit page will make 500 useless request on rewriting table.

If the rewrite table contains many url, the product edit page becomes very slow.

Other example for the FrontOffice with faceted search engine.

Other example for the FrontOffice with faceted search engine.

bibich added a commit that referenced this pull request Dec 22, 2015

Merge pull request #1852 from gillesbourgeat/feature/loop-disable-url…
…-rewriting

Add the possibility to disable the generation of url for the loops

@bibich bibich merged commit e9459fc into thelia:master Dec 22, 2015

2 checks passed

Scrutinizer 5 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Dec 22, 2015

@gillesbourgeat gillesbourgeat deleted the gillesbourgeat:feature/loop-disable-url-rewriting branch Dec 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment