[proposition] Add the possibility to disable the generation of url for the loops #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesbourgeat
changed the title
|
What is the goal of this PR ? Is there a perfomance problem with URL generation ? |
|
Not with the generator, but with too many useless request. Example for a site that has 300 brands, 200 categories.
If the rewrite table contains many url, the product edit page becomes very slow. Other example for the FrontOffice with faceted search engine.
|
bibich
added a commit
that referenced
this pull request
Dec 22, 2015
…-rewriting Add the possibility to disable the generation of url for the loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loops returns an url although there are no need.
This PR adds argument
return_urlthat can be used for disable the generation of urls.The default value for argument
return_urlistrue