Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add preg_quote for preg_replace base URL #2026

Closed

Conversation

Asenar
Copy link
Contributor

@Asenar Asenar commented Mar 4, 2016

No description provided.

@Asenar Asenar force-pushed the fix/tools-absolute-url-parameters branch from 4419215 to 3140054 Compare March 4, 2016 13:11
@gillesbourgeat
Copy link
Member

Hello,
Do you have an example of code to demonstrate the problem encountered ?

@Asenar
Copy link
Contributor Author

Asenar commented Mar 18, 2016

I don't have, I got an error when I first configured Thelia, and this changes fixed by problem (but maybe the real problem was elsewhere).

An error can happen when an argument name contains a / , .* or other regex thing.

$url = URL::getInstance()->absoluteUrl('path/to/action', array("cat1/cat2" => "v1", "p3" => "v2"));`

@Asenar Asenar force-pushed the fix/tools-absolute-url-parameters branch from 3140054 to 8a1bae7 Compare March 18, 2016 14:21
@Asenar Asenar force-pushed the fix/tools-absolute-url-parameters branch from 8a1bae7 to 613f008 Compare June 2, 2016 10:02
@roadster31
Copy link
Contributor

Manually merged to master

@roadster31 roadster31 closed this Aug 10, 2017
@roadster31 roadster31 mentioned this pull request Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants