Add param product_count_visible_only loop category #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roadster31
reviewed
Feb 21, 2017
| * @return int | ||
| */ | ||
| public function countAllProductsVisibleOnly() | ||
| { |
There was a problem hiding this comment.
Au lieu de recopier la fonction countAllProducts() pour juste ajouter le filtre par visibilité, il vaut mieux ajouter à countAllProducts() un paramètre visibleOnly qui est false par defaut. On ajoute le filtre par visibilité si ce paramètre est true.
Du coup, on aurait :
public function countAllProductsVisibleOnly() {
return countAllProducts(true);
}
Plus de recopie de code :)
There was a problem hiding this comment.
Merci ! Peux-tu rebaser ?
There was a problem hiding this comment.
je ne suis pas sur que cela ait marché
To match the doc -> loop category add param 'product_count_visible_only' if 'need_product_count' and 'product_count_visible_only' are true 'PRODUCT_COUNT' return only the visible products
|
Merci 👍 |
|
De rien :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the doc -> loop category
add param 'product_count_visible_only'
if 'need_product_count' and 'product_count_visible_only' are true
'PRODUCT_COUNT' return only the visible products