improve CacheClearTest #2418
Merged
improve CacheClearTest #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcbrr
commented
Aug 25, 2017
bcbrr
commented
- Prevent directory access failures when re-running these tests.
- Mark skipped tests as skipped.
bcbrr
force-pushed
the
teardown-cache-clear-test
branch
2 times, most recently
from
7031b1d
to
e3805f6
Compare
This seems to vary across systems, but the unwritable test cache created by testCacheClearWithoutWritePermission() can cause tests to fail when executed again.
bcbrr
force-pushed
the
teardown-cache-clear-test
branch
from
e3805f6
to
7985956
Compare
|
Hi, thanks for this PR. I'm working on Windows 7, and did not experienced failures with this test. What is your windows version ? |
|
It fails other test on any *nix on second run coz not restoring write perms. On windows it does not sense (I mean |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.