Tax calculation fixes, revamped #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roadster31
force-pushed
the
tax-calculation-fix-revamped
branch
from
d17b851
to
1fdaa1c
Compare
roadster31
force-pushed
the
tax-calculation-fix-revamped
branch
from
4d6dbfc
to
747d39e
Compare
roadster31
changed the title
| @@ -320,13 +321,21 @@ public function buildModelCriteria() | |||
| */ | |||
| public function parseResults(LoopResult $loopResult) | |||
| { | |||
| $lastLegacyOrderId = ConfigQuery::read('last_legacy_order_id', 0); | |||
There was a problem hiding this comment.
The term legacy is not really clear maybe last_miscalculated_order_id or last_not_rounded_order_id ?
There was a problem hiding this comment.
last_old_style_rounding_order_id ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #2680
This PR implements the "sum of rounded taxes" method for tax calculations, to prevent total price calculation errors when large quantities are ordered.
The PR also introduces an improved order-invoice order total block, and a PDF invoice improvement.