Add support for 'show_dialog' parameter when creating authorization url #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMPerez
requested changes
Apr 18, 2017
src/spotify-web-api.js
Outdated
| var request = AuthenticationRequest.builder() | ||
| .withPath('/authorize') | ||
| .withQueryParameters({ | ||
| 'client_id' : this.getClientId(), | ||
| 'response_type' : 'code', | ||
| 'redirect_uri' : this.getRedirectURI(), | ||
| 'scope' : scopes.join('%20'), | ||
| 'state' : state | ||
| 'state' : state, | ||
| 'show_dialog' : showDialog |
There was a problem hiding this comment.
It might be better to not pass it or initialise it to false. Otherwise devs that don't pass it will see show_dialog=undefined in the URL.
|
@ajhaupt7, are you interested in making the necessary changes? |
|
@thelinmichael @JMPerez comments make sense, I'll go ahead and make the changes |
…eating auth url (and adds test)
|
@thelinmichael @JMPerez made these changes and added a test for it -- its a bit verbose but does the trick |
JMPerez
approved these changes
Aug 24, 2017
atoami
pushed a commit
to atoami/react-native-spotify-web-api
that referenced
this pull request
Oct 20, 2018
…rl (thelinmichael#101) * Add support for 'show_dialog' parameter when creating authorization url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use the "show_dialog" parameter in my personal application to force users to approve the app each time they attempt to log in. This param is not currently supported by the wrapper -- for the time being I can create the auth url manually, but it was an easy addition so I added support for it here.