change addTracksToPlaylist to request body #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMPerez
requested changes
Apr 18, 2017
test/spotify-web-api.js
Outdated
| position: 10 | ||
| }); | ||
| console.log('inside'); |
There was a problem hiding this comment.
Could you remove this console.log?
There was a problem hiding this comment.
Shame on me :( .... fixed
JMPerez
approved these changes
Apr 24, 2017
atoami
pushed a commit
to atoami/react-native-spotify-web-api
that referenced
this pull request
Oct 20, 2018
* change uris to body in addTracksToPlaylist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the following note:
"Note: it is likely that passing a large number of track URIs as a query parameter will exceed the maximum length of the request URI. When adding a large number of tracks it is recommended to pass them in the request body, see below."
https://developer.spotify.com/web-api/add-tracks-to-playlist/
just changed withQueryParameters to withBodyParameters in addTracksToPlaylist