Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #33

Merged
merged 1 commit into from
May 12, 2015
Merged

Conversation

JMPerez
Copy link
Collaborator

@JMPerez JMPerez commented May 11, 2015

Implementing some tests that were skipped and fixing some others whose output has changed.

@thelinmichael
Copy link
Owner

It's been 38 minutes and this PR still hasn't built in Travis. It could be because it's not rebased on top of master although there aren't any conflicts.

http://docs.travis-ci.com/user/pull-requests/

@JMPerez
Copy link
Collaborator Author

JMPerez commented May 11, 2015

It seems it got stuck on one of the environments https://travis-ci.org/thelinmichael/spotify-web-api-node/builds/62125052

@coveralls
Copy link

Coverage Status

Coverage increased (+3.74%) to 77.84% when pulling ed3dc3b on JMPerez:master into afa6522 on thelinmichael:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.74%) to 77.84% when pulling cc84bbf on JMPerez:master into afa6522 on thelinmichael:master.

@thelinmichael
Copy link
Owner

@JMPerez, what did you do to "unstuck" it? Good stuff btw.

thelinmichael added a commit that referenced this pull request May 12, 2015
@thelinmichael thelinmichael merged commit 56800b3 into thelinmichael:master May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants