Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No autocomplete for nicks in direct messages #1459

Closed
ssk2 opened this issue Aug 25, 2017 · 5 comments
Closed

No autocomplete for nicks in direct messages #1459

ssk2 opened this issue Aug 25, 2017 · 5 comments
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Milestone
3.0.0

Comments

@ssk2
Copy link

ssk2 commented Aug 25, 2017

I can autocomplete a user's name in channels without problems but this functionality does not appear to exist for direct messages. This is desirable because occasionally my colleagues will only have notifications turned on for direct mentions of their name (whether in DM or in a channel).
@dgw
Copy link
Contributor

dgw commented Aug 26, 2017

👍

Could have sworn there was an issue open for this already, but I must have been thinking of #64, the opposite of this.

@xPaw
Copy link
Member

xPaw commented Aug 30, 2017

I guess autocompletion list should contain exactly 2 names in queries, yours and the user you're talking to? Should be relatively simple to do.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Aug 30, 2017
@MaxLeiter
Copy link
Member

I don't see a need to have your nick be completable

@dgw
Copy link
Contributor

dgw commented Aug 30, 2017

Need? Maybe not, but it wouldn't be the first client to do so.

@astorije
Copy link
Member

I agree with @MaxLeiter

@xPaw xPaw added Hacktoberfest help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels Oct 1, 2017
edbrannin added a commit to edbrannin/lounge that referenced this issue Oct 29, 2017
@edbrannin
add autocompleted names to private chats
5a663e9 
Fix thelounge#1459

thelounge#1459

Add rawNicks() to more easily get the list of nicks for the current
channel or chat without overly complicating its caller.
@edbrannin edbrannin mentioned this issue Oct 29, 2017
Merged
@xPaw xPaw removed the hacktoberfest label Nov 2, 2017
xPaw pushed a commit to edbrannin/lounge that referenced this issue Feb 28, 2018
@edbrannin @xPaw
add autocompleted names to private chats
4e67e55 
Fix thelounge#1459

thelounge#1459

Add rawNicks() to more easily get the list of nicks for the current
channel or chat without overly complicating its caller.
@xPaw xPaw added this to the 3.0.0 milestone Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
5 participants
@astorije @dgw @ssk2 @xPaw @MaxLeiter