Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset notification markers on document focus #1040

Merged
merged 1 commit into from Apr 15, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 15, 2017

Fixes #837.

If you have lounge open on a second monitor, receive a notification and switch to lounge, the favicon will stay red. This PR fixes that.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 15, 2017
@xPaw xPaw added this to the 2.3.0 milestone Apr 15, 2017
@xPaw xPaw force-pushed the focusin-reset-notifications branch from 303ce04 to d093a7f Compare April 15, 2017 15:43
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@astorije astorije merged commit 5bc1be1 into master Apr 15, 2017
@astorije astorije deleted the focusin-reset-notifications branch April 15, 2017 17:20
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…cations

Reset notification markers on document focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh highlight on window focus
2 participants