Create socket module #1060
Merged
Create socket module #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
approved these changes
Apr 21, 2017
|
I realised that modularising code like this might reveal code smells that we have. Win-win overall. |
astorije
approved these changes
Apr 22, 2017
|
lol pretty sure what triggered your code smell detector is that big comment that just screams my name |
astorije
added
the
Type: Feature
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…se-socket Create socket module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a small PR. Let's see how this goes.