Rendering fix (subpixel -> old one)

[bews]

Was discussed in #1071

[AlMcKinlay]

So, I have no idea what this code was even meant to do in the first place. @thelounge/maintainers anyone?

[xPaw]

It's a trick to force certain elements to be rendered on the GPU.

[AlMcKinlay]

Alright, is there a reason we are currently doing that?

[astorije]

I believe it was added for opening/closing channel list and user list, but why that was deferred to the GPU, that I have no idea...
Maybe the animation wasn't super smooth on mobiles?

[astorije]

Also, just to be clear, you reported this as a regression from Shout, but this was introduced 3 years ago by erming himself, so I'm not sure how The Lounge regressed from it :)

[xPaw]

Opening the sidebar uses translate3d, probably yes, to force GPU before it starts. Forcing GPU layer is also helpful for scroll performance, I was debugging some perf stuff in devtools and doing such a trick improved things. I cant provide more details right now as I am on mobile.

What i want to know, why does translateZ of 0 does different font rendering?

[astorije]

Note that it's not the first time that someone reports that the text in the user list is not as clean as the text of the chat window. Maybe some GPUs do not render things correctly and make simplifications instead?

[bews]

Also, just to be clear, you reported this as a regression from Shout, but this was introduced 3 years ago by erming himself, so I'm not sure how The Lounge regressed from it :)

Just checked myself, you're right. But Shout doesn't use subpixel rendering with this. Guess transform: translateZ(0); should be combined with something else make this change, but I couldn't find it. So the easiest way to fix this is to remove those lines.

[astorije]

@xPaw, @YaManicKill, what do we want to do with this?

[xPaw]

So this PR removes animation when opening or closing the channel list (with hamburger button).

@bews Can you test if adding will-change: transform fixes your issue? http://stackoverflow.com/a/32744881/2200891

[bews]

So this PR removes animation when opening or closing the channel list (with hamburger button).

No, it doesn't. What browser do you use? I can't reproduce it here.

Can you test if adding will-change: transform fixes your issue?

Yes, replacing

-webkit-transform: none !important;
transform: none !important;

with

will-change:transform;

fixes rending too. Should we use this way?

[bews]

It's really strange, but sidebar rendering was fixed by one of the recent commits, so it's not necessary to remove these lines anymore. Magic! Although there is a chance that this problem will appear again in future.

[astorije]

It's really strange, but sidebar rendering was fixed by one of the recent commits, so it's not necessary to remove these lines anymore.

Should we close this PR (for now at least) then?

[bews]

Should we close this PR (for now at least) then?

No, chat block is still broken, so at least other 2 lines should be removed.

[bews]

These ones.

[astorije]

According to this link given by @xPaw in #1120, translateZ(0); was used to improve performance in Safari and Safari Mobile.

Also, I'm thinking #1120 will supersede this, won't it, @xPaw? If so we should close for now.