Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include trickery to reduce paints and improve performance #1120

Merged
merged 2 commits into from Jun 20, 2017
Merged

Include trickery to reduce paints and improve performance #1120

merged 2 commits into from Jun 20, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 30, 2017 •
edited

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Apr 30, 2017
@xPaw xPaw added this to the 2.3.0 milestone Apr 30, 2017
@astorije astorije modified the milestones: 2.3.1, 2.3.0 May 1, 2017
@astorije astorije mentioned this pull request May 1, 2017
Closed
@astorije
Copy link
Member

astorije commented Jun 8, 2017

@xPaw, is this ready for review?

@astorije astorije self-requested a review June 8, 2017 06:10
@xPaw
Copy link
Member Author

xPaw commented Jun 8, 2017

@astorije should be.

@astorije astorije modified the milestones: 2.3.2, 2.3.1 Jun 9, 2017
@astorije
Copy link
Member

(Simply rebased on master, no code change at all)

astorije
astorije reviewed Jun 12, 2017
View reviewed changes
client/css/style.css
@@ -374,8 +370,7 @@ kbd {
}

#viewport.rt #chat .sidebar {
-webkit-transform: translate3d(180px, 0, 0);
transform: translate3d(180px, 0, 0);
right: -180px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the links you posted in PR description, I understand that right would need a repaint as opposed to transform. Is that what will-change: transform; below is trying to prevent?
Also, how does will-change: transform; work if you removed the transform property above?

Sorry, still trying to understand how all of this works...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that it would be doing a repaint, however this was needed to fix the font rendering issue.

@astorije astorije requested a review from AlMcKinlay June 20, 2017 05:51
AlMcKinlay
AlMcKinlay approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will make it a bit easier on my poor ageing phone :-P

@astorije
Copy link
Member

@YaManicKill, what do you think, merge this before or after #1175? :/

@AlMcKinlay
Copy link
Member

Before is fine, afaics it doesn't edit any of the code I have edited.

@xPaw xPaw merged commit 2091a5b into master Jun 20, 2017
@xPaw xPaw deleted the xpaw/scroll-perf branch June 20, 2017 10:18
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@xPaw
Merge pull request thelounge#1120 from thelounge/xpaw/scroll-perf
fdbcb50 
Include trickery to reduce paints and improve performance
@astorije astorije mentioned this pull request Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

@AlMcKinlay AlMcKinlay AlMcKinlay approved these changes

Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xPaw @astorije @AlMcKinlay