Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "reload page" button when Lounge fails to start. #1150

Merged
merged 1 commit into from Jun 10, 2017
Merged

Add "reload page" button when Lounge fails to start. #1150

merged 1 commit into from Jun 10, 2017

Conversation

bews
Copy link
Contributor

@bews bews commented May 9, 2017

It's hard to reload when in fullscreen mode:

screenshot_20170509-161420

AlMcKinlay
AlMcKinlay approved these changes May 9, 2017
View reviewed changes
Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Let's not merge until 2.3.0 is released incase we have some bug fixes.

@AlMcKinlay AlMcKinlay added this to the 2.3.1 milestone May 9, 2017
@AlMcKinlay AlMcKinlay added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label May 9, 2017
xPaw
xPaw approved these changes May 9, 2017
View reviewed changes
client/js/loading-slow-alert.js Outdated
@@ -15,3 +15,7 @@ setTimeout(function() {
element.style.display = "block";
}
}, 5000);

document.getElementById("loading-slow-reload").onclick = function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use addEventListener.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bews, could you fix that please? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@astorije astorije self-requested a review June 8, 2017 05:46
@astorije
Copy link
Member

astorije commented Jun 8, 2017

It would be really sweet if it would look like the reload button on the chat page for consistency, but I won't push too much if other @thelounge/maintainers don't like that idea :)

I can't get it to show up right now, but 100%-wide red ribbon that turns green when clicking on it.

@AlMcKinlay
Copy link
Member

I'm not sure I'm happy with the idea of it looking the same as that, it would feel very out of place on this screen, and we plan to remove the other one anyway. I think what we have here is nicer. I understand the consistency though.

@bews
Copy link
Contributor Author

bews commented Jun 8, 2017

It would be really sweet if it would look like the reload button on the chat page for consistency

I've thought about it too, but it doesn't look good. Also, #1185 PR removes that wide button completely, so I think it's better to keep current one.

@astorije astorije modified the milestones: 2.3.2, 2.3.1 Jun 9, 2017
astorije
astorije requested changes Jun 9, 2017
View reviewed changes
client/js/loading-slow-alert.js Outdated
@@ -15,3 +15,7 @@ setTimeout(function() {
element.style.display = "block";
}
}, 5000);

document.getElementById("loading-slow-reload").onclick = function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bews, could you fix that please? :)

astorije
astorije approved these changes Jun 10, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astorije astorije merged commit 1a6f2fc into thelounge:master Jun 10, 2017
@bews bews deleted the bews/dev-9-reload branch June 10, 2017 17:32
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije
Merge pull request thelounge#1150 from bews/bews/dev-9-reload
3afe5d8 
Add "reload page" button when Lounge fails to start.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

@xPaw xPaw xPaw approved these changes

@AlMcKinlay AlMcKinlay AlMcKinlay approved these changes

Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bews @astorije @AlMcKinlay @xPaw