Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use persistent commit url for shout's changelog #12

Merged
merged 1 commit into from Feb 13, 2016
Merged

Use persistent commit url for shout's changelog #12

merged 1 commit into from Feb 13, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Feb 12, 2016

If the changelog file changes or gets moved in Shout repo, our link will still work.

@AlMcKinlay
Copy link
Member

Sensible change. 👍 from me

@astorije
Copy link
Member

I actually would rather follow the master version as the CHANGELOG might be updated someday (look at v0.52.0 for example, it just says "???"). I don't think the URL will change anytime soon, so probability that it gets improved seems higher than probability it gets changed.

Of course, it's not definitive and we will probably change that when a lots of new versions are published, for the reason you mentioned. Just short term I'd prefer master.

Does that make sense, @xPaw and @YaManicKill?

@astorije astorije added the Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these. label Feb 13, 2016
@AlMcKinlay
Copy link
Member

Well, the thing ist hat if the changelog ever changes, it'll be out of date, generally. The most likely reason for the changelog changing is they have a new version with new changes. We won't be based on top of that, so it means that people going to that will probably see some stuff that isn't in the lounge. So I'm personally for not following master.

@xPaw
Copy link
Member Author

xPaw commented Feb 13, 2016

I actually would rather follow the master version as the CHANGELOG might be updated someday (look at v0.52.0 for example, it just says "???").

The only thing that needs fixing that changelog is 0.52.0 as you mentioned. If that gets fixed, our changelog url should be pinned to the commit that fixes that. There is no need to link to master, as we forked from 0.53, and future changelogs won't make sense.

erming/shout@0.51.2...v0.52.0

@astorije
Copy link
Member

Note that for the reasons you both mentioned, I anchored the link to #0530--2016-01-07, so that it always shows from v0.53.0 and backwards. But that's a detail so I won't argue furthermore, this will become less and less relevant with each new release of The Lounge anyway.
👍

astorije added a commit that referenced this pull request Feb 13, 2016
Use persistent commit url for shout's changelog
@astorije astorije merged commit ee43575 into thelounge:master Feb 13, 2016
@xPaw xPaw deleted the patch-1 branch February 13, 2016 18:25
@astorije astorije assigned AlMcKinlay and unassigned AlMcKinlay Feb 14, 2016
@AlMcKinlay
Copy link
Member

Having fun, @astorije ? :-P

@astorije
Copy link
Member

astorije commented Mar 9, 2016

Yeah, I messed something up, sorry for the noise :-/ Should be good this time...

@astorije astorije added this to the 1.0.1 milestone Apr 1, 2017
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
brunnre8 pushed a commit to brunnre8/thelounge that referenced this pull request Apr 6, 2021
minor enhancements + support PMs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants