Improve the PR tester script a bit

[astorije]

I know it's probably not the cleanest / most error-proof solution, but it does the job in most cases. What I wanted to add most obviously is the git rebase master part, to make sure what we are testing with these PRs is as up-to-date with master as possible.

Of course, if your master is not up-to-date itself, there will be troubles, but devs' masters should always be up-to-date... right? 😉

Anyway, I'm using this myself a lot to test PRs when reviewing, so I'd surely appreciate those!

[AlMcKinlay]

I feel like making it rebase on master would probably be better being an option, but I doubt many people other than you use this script @astorije, so go for it.

Just a think to remember that if the rebase fails, the script will continue to run the other commands. Probably not much of an issue.

[astorije]

but I doubt many people other than you use this script @astorije, so go for it.

Yeah, and I'd be totally willing to improve that script if other reviewers find this useful (how can you review without it, I literally use it multiple times a week 😅), I'd be totally happy to make it more resilient.

Just a think to remember that if the rebase fails, the script will continue to run the other commands.

Actually, it would stop thanks to the set -e at the top, which is exactly why I'm not too concerned about having it fail.

[AlMcKinlay]

how can you review without it

I mean, I have an equivalent, but it's not exactly the same. It's just a 1-liner.

Actually, it would stop thanks to the set -e at the top

Huh, TIL