Remove user link color override on dark theme #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a UI glitch on hover when colored nicknames are disabled on Morning and Zenburn.
astorije
added
the
Type: Bug
xPaw
approved these changes
Jul 26, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…litch Remove user link color override on dark theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You see, that's precisely why I question every new setting: I will always forget to test one of the many combinations we have 😅
Fixes #1372, thanks to @Jay2k1 for noticing this!
This fixes a UI glitch on hover when colored nicknames are disabled on Morning and Zenburn. The UI on colored nicknames actually does not respect this color override anyway, as it just shows the colored nickname with reduced opacity.
The issue here was that the color was changed right away on those themes when colored nicknames are disabled, then transitioned to the opacity.
My fix simply gets rid of those, so the hover effect is theme-specified color + reduced opacity (in which case, transition set in base CSS works fine).