Remove 10-second interval to trim buffer #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
astorije
reviewed
Aug 13, 2017
| $(this).remove(); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Is it worth putting this in a debounce function so it doesn't fire more than once every N seconds (10?)? I'm concerned this could be called a lot in very active channels.
There was a problem hiding this comment.
From the channel:
<xPaw> astorije, I remember testing the message trimmer in my queue PR on twitch channels
<astorije> So you're saying no debounce needed, right?
<xPaw> it produced like multiple new message per seconds, and while debugging it, I saw nothing that pointed towards this code
<xPaw> so yes, shouldnt be needed
astorije
approved these changes
Aug 13, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Remove 10 second interval to trim buffer
astorije
changed the title
astorije
added
Meta: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96. Split from #1041.