Refactor authentication flow #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
Type: Bug
xPaw
commented
Aug 13, 2017
| @@ -470,3 +466,13 @@ function auth(data) { | |||
| localAuth(client, data.user, data.password, authCallback); | |||
| } | |||
| } | |||
|
|
|||
| function reverseDnsLookup(ip, callback) { | |||
There was a problem hiding this comment.
Rewrote this function to be an independent helper. This improves authentication flow (e.g. remember me in webirc most likely did not work before).
xPaw
commented
Aug 13, 2017
| const socket = this; | ||
| let client; | ||
|
|
||
| const finalInit = () => initializeClient(socket, client, !!data.remember, data.token || null); |
There was a problem hiding this comment.
I am now passing token so that we have a session-like reference to it. This will be required for push notifs and other stuff later.
xPaw
commented
Aug 13, 2017
| } else { | ||
| init(socket); | ||
| socket.emit("auth", {success: true}); |
There was a problem hiding this comment.
Moved these 2 lines here so that we don't have a big if/else in init.
xPaw
commented
Aug 13, 2017
| @@ -300,13 +300,13 @@ Client.prototype.updateSession = function(token, ip, request) { | |||
| const agent = UAParser(request.headers["user-agent"] || ""); | |||
| let friendlyAgent = ""; | |||
|
|
|||
| if (agent.browser.name.length) { | |||
There was a problem hiding this comment.
Fixes crash if UA is missing.
astorije
approved these changes
Aug 13, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Refactor authentication flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is whitespace heavy so review with
?w=1.