Invoke handlebars outside of grunt, generate sourcemap #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Bug
|
Works fine here, plus sourcemaps are really nice to have to help debugging instead of editing and rebuilding. Big 👍 from me. |
|
Yeah, looks good to me. To be honest, I'd be for removing grunt entirely if the only thing we are now doing with it is combining the lib files. We don't use any of the big features of grunt, so we may as well just go all in on the npm scripts. Either way, 👍 from me, very happy with sourcemaps (always good). Merging. |
AlMcKinlay
added a commit
that referenced
this pull request
Mar 7, 2016
Invoke handlebars outside of grunt, generate sourcemap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65 (template compiling on windows).