Gracefully quit on Ctrl+C
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
astorije
approved these changes
Aug 30, 2017
| } | ||
|
|
||
| // Forcefully exit after 3 seconds | ||
| suicideTimeout = setTimeout(() => process.exit(1), 3000); |
There was a problem hiding this comment.
Maybe another log.info in there, like "Something went wrong, force-quitting now"? Also, could do 5000 just in case, but whatever.
There was a problem hiding this comment.
I don't think it's necessary to add a message.
|
@xPaw feel free to address comment or not, then to merge or let @YaManicKill review first. I'm good either way. |
AlMcKinlay
approved these changes
Aug 31, 2017
| @@ -499,7 +499,10 @@ Client.prototype.quit = function() { | |||
| const socket = sockets.connected[user]; | |||
|
|
|||
| if (socket) { | |||
| socket.emit("sign-out"); | |||
| if (signOut) { | |||
There was a problem hiding this comment.
This feels like an unrelated fix.
There was a problem hiding this comment.
It's not, we don't want to sign out users on server close.
There was a problem hiding this comment.
Oh woops, I missed that we were already sending sign-out. Sounds good.
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Gracefully quit on Ctrl+C
astorije
changed the title
astorije
changed the title
Ctrl+C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268