Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move even more code out of lounge.js #1500

Merged
merged 3 commits into from Sep 11, 2017
Merged

Move even more code out of lounge.js #1500

merged 3 commits into from Sep 11, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Sep 5, 2017

No description provided.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Sep 5, 2017
@xPaw xPaw added this to the 2.5.0 milestone Sep 5, 2017
@xPaw xPaw requested a review from AlMcKinlay September 5, 2017 16:23
astorije
astorije reviewed Sep 6, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+112 -162 on first commit, are we losing anything?

@astorije
Copy link
Member

astorije commented Sep 6, 2017

Last, sorry

@xPaw
Copy link
Member Author

xPaw commented Sep 6, 2017

@astorije good catch, I somehow removed incorrect code in last commit.

astorije
astorije approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read the code but tested this and it works fine. Except "Show more" that doesn't work, but I could repro the same bug on master.

@xPaw xPaw merged commit 8de7f44 into master Sep 11, 2017
@xPaw xPaw deleted the xpaw/even-more-modules branch September 11, 2017 18:38
@AlMcKinlay AlMcKinlay removed their request for review September 26, 2017 07:56
@AlMcKinlay AlMcKinlay removed their assignment Sep 26, 2017
@astorije astorije changed the title Move even more code out of lounge.js Move even more code out of lounge.js Sep 29, 2017
@astorije astorije added the Meta: Internal This is an internal codebase change (testing, linting, etc.). label Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.). Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xPaw @astorije @AlMcKinlay