Enable no-console and no-alert ESLint rules
#1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
astorije
commented
Sep 18, 2017
| @@ -35,8 +35,6 @@ const socket = io({ | |||
| }); | |||
| // Hides the "Send Message" button | |||
| $("#submit").remove(); | |||
|
|
|||
| console.error(data); | |||
There was a problem hiding this comment.
We really shouldn't be using console.xxx in the browser...
astorije
force-pushed
the
astorije/eslint-console
branch
from
0075377
to
aa377ee
Compare
astorije
commented
Sep 18, 2017
| @@ -79,8 +79,6 @@ if (process.env.NODE_ENV === "production") { | |||
| sourceMap: true, | |||
| comments: false | |||
| })); | |||
| } else { | |||
| console.log("Building in development mode, bundles will not be minified."); | |||
There was a problem hiding this comment.
I don't believe this is really helpful at this point, might as well not have it.
xPaw
approved these changes
Sep 18, 2017
AlMcKinlay
approved these changes
Sep 18, 2017
There was a problem hiding this comment.
Approve in general, but I think we should switch to a logging framework rather than disabling the console logging whenever we want to log. I use winston on most things.
Then you use the framework for the proper logging, and console.log when developing, that way you don't need all the eslint comments and you don't let dev logging slip through.
But this is good enough for now.
| spaced-comment: [error, always] | ||
| strict: error | ||
| template-curly-spacing: error | ||
| yoda: error |
astorije
added
the
Meta: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We almost slipped in a few
console.logstatements so this should make it safer. Outside of the current occurrences we have, we shouldn't need any more in the code, or at least not without explicitly acknowledging them.