Use Mousetrap for image viewer shortcuts
#1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
astorije
force-pushed
the
astorije/mousetrap-preview
branch
from
a4b8b99
to
2c0fc67
Compare
xPaw
approved these changes
Sep 24, 2017
astorije
changed the title
Mousetrap for image viewer shortcuts
astorije
added
the
Meta: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am aware of the
keybinds.jsfile, but I think keyboard shortcuts should be located next to their respective feature. In fact, as we modularizing our code into packages, we'll have to do that anyway.Also, I didn't want to have to export stuff like
closeImageViewerjust for that.