Add info message before calling packageJson
#1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
xPaw
force-pushed
the
xpaw/install-msg
branch
from
f6afbe8
to
4a19fbc
Compare
astorije
reviewed
Sep 28, 2017
src/command-line/install.js
Outdated
| @@ -21,6 +21,8 @@ program | |||
| return; | |||
| } | |||
|
|
|||
| log.info("Checking requested package data on npm..."); | |||
There was a problem hiding this comment.
What about Retrieving information about the package, please wait...?
There was a problem hiding this comment.
Perhaps Retrieving information about the package... ?
astorije
changed the title
packageJson
xPaw
force-pushed
the
xpaw/install-msg
branch
from
4a19fbc
to
1c4d935
Compare
astorije
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some network hiccup, so the CLI seemingly didn't do anything until the packageJson callback got called and the message that package is installing displayed.