Use thelounge instead of lounge when it comes to external packages
#1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
astorije
commented
Sep 29, 2017
| log.warn(`Specified theme ${colors.yellow(packageName)} doesn't have required information.`); | ||
| return; | ||
| } | ||
| return module.lounge; | ||
| return module.thelounge; |
There was a problem hiding this comment.
Unrelated to this PR, and also I realize that it doesn't hurt to be on the safe side, but now that the install command takes care of checking the metadata, maybe we should assume that if a package reaches this point, it has the correct metadata, no?
There was a problem hiding this comment.
It's better to be on the safe side.
xPaw
approved these changes
Sep 29, 2017
This was referenced Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep having confusions between
loungeandtheloungeeverywhere (sorry.....).When v3 shows up, we should be able to get rid of the inconsistency entirely. In the meantime, new stuff, especially external packages that will rely on fairly stable contracts, should honor that to make the transition easier. Apart from those, nothing should be problematic.