Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give chat timestamp a fix width to fix message alignment issues #1597

Merged
merged 1 commit into from Oct 2, 2017

Conversation

astorije
Copy link
Member

@astorije astorije commented Oct 1, 2017

Fixes #1581.

I gave 5px headroom to the timestamp width I get on my laptop. Tested with/without seconds, on Chrome/Safari/Firefox on Mac, Chrome on Android. Would be nice if someone on Windows and/or Linux could test, just to be sure.

Before After
screen shot 2017-10-01 at 01 12 41 screen shot 2017-10-01 at 01 12 22

@astorije astorije added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Oct 1, 2017
@astorije astorije added this to the 2.5.0 milestone Oct 1, 2017
@dgw
Copy link
Contributor

dgw commented Oct 1, 2017

Yay for fixing this! But is there a way to fix the width relative to the font size? I can't get in and play around right now, however it seems like something around 5-6em would do unless I'm forgetting something important about CSS sizing…

@astorije
Copy link
Member Author

astorije commented Oct 1, 2017

That could work. What do you think, @xPaw?

@astorije
Copy link
Member Author

astorije commented Oct 2, 2017

@dgw, after chatting with @xPaw, we decided to go for pixels as a quick fix for #1581 because we're not 100% sure how that would behave under different fonts, sizes, etc.

That being said, if you or anyone wants to give it a try, we'd totally consider it in the next release while keeping the quickfix for this release.
I'm merging that now to be able to release v2.5.0-rc.2 right now, but feel free to object and we could totally discuss it before v2.5.0 happens if that seems unwise to you!

@astorije astorije merged commit 50d49a2 into master Oct 2, 2017
@astorije astorije deleted the astorije/fix-time-width branch October 2, 2017 02:24
@dgw
Copy link
Contributor

dgw commented Oct 2, 2017

Eh, I don't think there's anything wrong with pixels unless font sizes are going to change a lot. This isn't something that would be worth holding back v2.5.0 stable for. If I (or anyone) get around to playing with it in time, fine; if not, also fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants