Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send an email on a successful build #172

Merged
merged 1 commit into from Mar 9, 2016
Merged

Don't send an email on a successful build #172

merged 1 commit into from Mar 9, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 9, 2016

No description provided.

@@ -3,6 +3,10 @@ node_js:
- '5.6'
- '4.3'
- '0.12'
notifications:
email:
on_success: never
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this turn off "fixed" emails?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Do we really need them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I guess most of the time you'll be watching travis after you have a failed build?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the change option, but I guess I'm not the receiver so.. 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaManicKill Yeah, we would see the build status in PR anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer change as well, but as long as broken builds trigger an email, I'm OK.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to change, and that triggers an email whenever a branch is created, which is not desirable, imo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, wasn't aware of that... Thanks!

@astorije astorije self-assigned this Mar 9, 2016
astorije added a commit that referenced this pull request Mar 9, 2016
Don't send an email on a successful build
@astorije astorije merged commit f3685f7 into master Mar 9, 2016
@astorije astorije deleted the xpaw/travis branch March 9, 2016 15:26
@astorije astorije added this to the 1.4.0 milestone Oct 8, 2016
@astorije astorije added the Meta: Internal This is an internal codebase change (testing, linting, etc.). label Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants