Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP2 #174

Merged
merged 1 commit into from
Mar 19, 2016
Merged

Add support for HTTP2 #174

merged 1 commit into from
Mar 19, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 9, 2016

With this module you can create HTTP2 / SPDY servers in node.js with natural http module interface and fallback to regular https (for browsers that don't support neither HTTP2, nor SPDY yet).

http2 module does not work with Express. Closes #173.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Mar 9, 2016
@astorije
Copy link
Member

astorije commented Mar 9, 2016

FYI, Google has deprecated SPDY and will completely drop it this year. I understand this package is not affiliated to Google, but it might be worth looking at consequences a bit more.

@xPaw
Copy link
Member Author

xPaw commented Mar 9, 2016

Yeah, but from the look of things, the package isn't going anywhere and supports HTTP2 just fine.

@astorije astorije self-assigned this Mar 19, 2016
@astorije
Copy link
Member

@xPaw, I'll try to take a look at this over the week-end.

@maxpoulin64
Copy link
Member

Seems to be working just fine, 👍

Note: needs to be served over SSL for Chrome to use HTTP/2. Took me a short while before I got it working because of that, so HTTP/1.1 also works just fine still.

@xPaw
Copy link
Member Author

xPaw commented Mar 19, 2016

@maxpoulin64 Correct, HTTP2 is TLS only by design (of the protocol).

@astorije
Copy link
Member

FYI, I have been reading this article which covers HTTP/2 with this package, good read if someone wants to know more about it.

Yeah, but from the look of things, the package isn't going anywhere and supports HTTP2 just fine.

Indeed:

Whilst spdy is being deprecated, node-spdy has a fantastic API and full support for HTTP/2 and fallback to HTTPS, so there is currently no reason not to use it in production.

I noted the following too, that I could read in different places:

It’s worth noting, Express 5.0 will eventually have HTTP/2 support out the box, although there is uncertainty within the community as to when Express 5.0 will be released [...]

So we're not there yet, but someday we'll be able to simply rely on Express to deal with it on its own, pretty cool!

@maxpoulin64 Correct, HTTP2 is TLS only by design (of the protocol).

Not quite, they ended up adding non-HTTPS support to HTTP/2 in the end, to please folks who were against having an HTTPS-only protocol. HTTPS is however the default, and apparently it's a pain to set up non-HTTPS for HTTP/2, and lots of clients would not support it anyway...

So in a nutshell, very nice to have The Lounge serving HTTP/2 pages by default when you enable HTTPS!
👍 and merging.

astorije added a commit that referenced this pull request Mar 19, 2016
@astorije astorije merged commit 05be0ff into master Mar 19, 2016
@astorije astorije deleted the xpaw/http2 branch March 19, 2016 22:06
@astorije astorije added this to the 1.4.0 milestone Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants