Keep track of highlights when user is offline #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
Type: Feature
What do you mean by that? I'm not too thrilled by fixing this on the server when I think it would be nicer to have that on the front-end. What prevented you to do so, @xPaw? |
|
@astorije Same reason unread counter is server side. If you get highlighted and then the channel receives 500 messages, when you open the client, that message won't be loaded, thus you don't know if you were highlighted. |
|
👍 and merging |
maxpoulin64
added a commit
that referenced
this pull request
Mar 15, 2016
Keep track of highlights when user is offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user is offline and channel gets a lot of messages, when the user comes back online, the unread counter badge won't be white even if the user was mentioned in that channel, that's because badge only turns white if any message in current buffer contains a highlight.