Add tests for the sortUsers method #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
force-pushed
the
astorije/test-sort-users
branch
from
b43ea88
to
68952fe
Compare
|
|
||
| describe("Chan", function() { | ||
| describe("#sortUsers()", function() { | ||
| // TODO Use this version instead when switching to irc-framework |
There was a problem hiding this comment.
Remove these TODOs, it's unnecessary. After this PR is merged, just update the tests in ir-framework branch.
|
Add a couple of users with different cases in the name, and a couple of special symbols to test case insensitive sorting too. |
astorije
force-pushed
the
astorije/test-sort-users
branch
2 times, most recently
from
1715059
to
a6b452d
Compare
astorije
added
the
Type: Feature
|
Also, should test file name match tested file name (like currently)? Or |
astorije
force-pushed
the
astorije/test-sort-users
branch
from
a6b452d
to
6495f17
Compare
xPaw
added a commit
that referenced
this pull request
Mar 16, 2016
Add tests for the sortUsers method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behold... tests!
I'm usually not too fond of having placeholder code until something happens, but considering @xPaw is making good progress by himself on #167, I thought I would give a minor hand by providing the lines to change to have these tests running in his PR.And as a matter of fact... these tests are currently failing on #167 :D
Nevermind, removed the placeholders, will re-add when time comes.
I hope you like 'em, let me tell you this is the beginning of a whole lot of PRs about testing I'm planning to submit :-)
(Yes, I'm adding Chai in the
devDependencies, but it's really worth it!)