Add a very basic test for Network#export #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
| network.channels.push(new Chan({name: "#thelounge"})); | ||
| network.channels.push(new Chan({name: "&foobar"})); | ||
|
|
||
| expect(network.export()).to.deep.equal({ |
There was a problem hiding this comment.
Will this test fail if we add new properties to export?
There was a problem hiding this comment.
Yes, on purpose. If changing the behavior or .export(), it must be a conscious choice and therefore the test(s) should be updated :-)
There was a problem hiding this comment.
Ah that's fine, the export function picks what entries to export. Confused it with toJSON.
astorije
force-pushed
the
astorije/test-network-export
branch
from
22ed0a3
to
f35b0df
Compare
xPaw
added a commit
that referenced
this pull request
Mar 16, 2016
Add a very basic test for Network#export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic, naive test but my plan was to have the minimal possible coverage rather than an extensive test suite. Will improve over time.
Btw, CI will pass after #197 is merged and this PR is rebased off master.