Define which message types should not be logged

[xPaw]

whois log is currently logged as undefined whois which isn't at all useful.

[MaxLeiter]

Msg.NonLoggableTypes = { [Msg.Type.BANLIST]: true, ...}

maybe?

[xPaw]

Doesn't work on node 4 afaik.

[astorije]

$ nvm use 4
Now using node v4.8.4 (npm v2.15.11)
$ node
> a = 42
42
> { [a]: 1}
{ '42': 1 }

🤷‍♂️

[astorije]

Why not add a method to the Msg class instead that would do:

function isLoggable() {
	return this.type !== Msg.Type.MOTD &&
		this.type !== Msg.Type.BANLIST &&
		this.type !== Msg.Type.WHOIS;
}

And in writeUserLog:

if (!msg.isLoggable()) {
	return false;
}

It seems more idiomatic to me, no?
(I went for isLoggable and not isNotLoggable because it's fairly common practice to avoid negated boolean functions)

Bonus, you can get rid of const Msg = require("./msg"); 😁

[astorije]

$ nvm use 4
Now using node v4.8.4 (npm v2.15.11)
$ node
> a = 42
42
> { [a]: 1}
{ '42': 1 }

🤷‍♂️

[astorije]

Why not add a method to the Msg class instead that would do:

function isLoggable() {
	return this.type !== Msg.Type.MOTD &&
		this.type !== Msg.Type.BANLIST &&
		this.type !== Msg.Type.WHOIS;
}

And in writeUserLog:

if (!msg.isLoggable()) {
	return false;
}

It seems more idiomatic to me, no?
(I went for isLoggable and not isNotLoggable because it's fairly common practice to avoid negated boolean functions)

Bonus, you can get rid of const Msg = require("./msg"); 😁

[xPaw]

Changed it to what @astorije suggested.

[AlMcKinlay]

Yes, much nicer.