Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements of the context menu UI #212

Merged
merged 3 commits into from
Mar 20, 2016

Conversation

astorije
Copy link
Member

  • Blur the shadow around the context menu box
  • Add a 2px radius to the context menu box
  • Add a divider to allow for margin around it, and prepare future item additions
  • Add margins at the top and bottom of the context menu, as well as around the divider, to replicate common context menu behavior
  • Use a white background X Font Awesome icon to close a chat (not × &times on purpose because it doesn't look as nice on white background, but we can improve if necessary)
  • Smooth icons of context menu items

Ideally, I would like to find a nice contrasted color for the :hover, allowing us to invert text/icon colors when highlighting an item, but I couldn't find a nice one. Any suggestion?

Before After
screen shot 2016-03-20 at 17 28 09 screen shot 2016-03-20 at 17 25 49
screen shot 2016-03-20 at 17 31 04 screen shot 2016-03-20 at 17 25 58

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Mar 20, 2016
@astorije astorije force-pushed the astorije/improve-context-menu-design branch from c3896b0 to f8807df Compare March 20, 2016 21:40
@xPaw
Copy link
Member

xPaw commented Mar 20, 2016

👍

xPaw added a commit that referenced this pull request Mar 20, 2016
…design

Minor enhancements of the context menu UI
@xPaw xPaw merged commit 7736d19 into master Mar 20, 2016
@xPaw xPaw deleted the astorije/improve-context-menu-design branch March 20, 2016 21:47
@astorije astorije added this to the 1.4.0 milestone Oct 8, 2016
@xPaw xPaw removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants