Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #foo channel from default config #22

Merged
merged 1 commit into from
Feb 14, 2016

Conversation

astorije
Copy link
Member

I actually don't see the point of having #foo as a default channel... Maybe there is a channel exactly design for that (testing that your client is well connected) that we should use, otherwise simply #thelounge is enough IMO.

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Feb 13, 2016
@AlMcKinlay
Copy link
Member

👍 from me then, looks good.

In this circumstance, do we need another +1 from someone other than you because it's your PR?

@xPaw
Copy link
Member

xPaw commented Feb 14, 2016

👍 ¯_(ツ)_/¯

@astorije
Copy link
Member Author

I mentioned this today in the review process.
Basically: only one 👍 from another project maintainer if PR is from a project maintainer (what we were doing on erming/shout) unless this is a non-minor change that would likely be debated a little bit. We should use common sense to determine if it's minor or if people will have opinion :-)

astorije added a commit that referenced this pull request Feb 14, 2016
Remove #foo channel from default config
@astorije astorije merged commit 665cfbe into master Feb 14, 2016
@astorije astorije deleted the astorije/remove-foo-channel branch February 14, 2016 20:29
@astorije astorije assigned AlMcKinlay and unassigned AlMcKinlay Feb 25, 2016
@astorije astorije added this to the 1.0.2 milestone Apr 1, 2017
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
brunnre8 pushed a commit to brunnre8/thelounge that referenced this pull request Apr 6, 2021
Lookup commits by !gh <commit> command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants