Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display whitespace properly #239

Merged
merged 1 commit into from Apr 6, 2016
Merged

Conversation

maxpoulin64
Copy link
Member

Fixes alignment in many server's motd as well as in-channel ASCII art

Before

before

After

after

@maxpoulin64 maxpoulin64 self-assigned this Apr 2, 2016
@maxpoulin64 maxpoulin64 added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels Apr 2, 2016
@astorije
Copy link
Member

astorije commented Apr 3, 2016

Yes!! Thanks for that!!
I'll try some edge cases before giving my approval though.

@maxpoulin64
Copy link
Member Author

@astorije Just fixed a bug with action messages. I think we should be covered now.

@xPaw
Copy link
Member

xPaw commented Apr 3, 2016

Why not set it on #chat .msg .text?

@maxpoulin64
Copy link
Member Author

@xPaw because it would break the other action templates due to extra whitespace. I had to edit msg.tpl and msg_action.tpl to glue the text right on the span, otherwise the extra tabs/spaces before and after would be displayed as well, making a mess. So I targetted those and only those to avoid bad surprises and WTF with the action templates.

@xPaw
Copy link
Member

xPaw commented Apr 3, 2016

Ah yes, good point. Have you tested if super long/unicode lines overflow correctly with this patch?

@maxpoulin64
Copy link
Member Author

It should be no different than before, since it's pre-wrap and not just pre. It should only affect tabs and space, but I admit I haven't tested that case. I can check a bit later if you want.

@xPaw
Copy link
Member

xPaw commented Apr 3, 2016

I'm just wondering if it's going to conflict with word-wrap: break-word; we have on .msg or not.

@xPaw
Copy link
Member

xPaw commented Apr 3, 2016

Unrelated note, can we get a overflow: hidden in that same selector? So that zalgo text and other crap doesn't overflow onto other lines.

Fixes alignment in many server's motd as well as in-channel ASCII art
@maxpoulin64
Copy link
Member Author

@xPaw makes sense, updated.

@astorije
Copy link
Member

astorije commented Apr 6, 2016

Good job, guys! 👍

@astorije astorije merged commit bf0d584 into thelounge:master Apr 6, 2016
@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. and removed second review needed labels Apr 6, 2016
@maxpoulin64 maxpoulin64 deleted the white-space branch April 16, 2016 11:22
@astorije astorije added this to the 1.5.0 milestone Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants