Do not display incorrect nick when switching to a non connected network #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
Type: Bug
|
Whoops, that one went unnoticed for a while. 👍 This seems pretty minor to me, feel free to merge if you feel the same. |
|
👍 |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Do not display incorrect nick when switching to a non connected network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it only called
setNickif the network had a nick, so it would keep displaying the nick from the network you switched from, this PR fixes that.31margin number, and calculates the margin correctly.#nickpanel if the network has no nick (e.g. while lauching lounge or connecting)