Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest.json for nicer mobile experience #310

Merged
merged 1 commit into from
May 20, 2016
Merged

Conversation

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label May 10, 2016
@astorije astorije self-assigned this May 10, 2016
@maxpoulin64
Copy link
Member

I like that a lot. It's just a color, but it sure does make The Lounge feel a lot more native/integrated! 👍

@xPaw xPaw mentioned this pull request May 12, 2016
@xPaw xPaw added this to the ★ Next Release milestone May 13, 2016
@@ -9,6 +9,7 @@
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
<meta name="mobile-web-app-capable" content="yes">
<meta name="referrer" content="no-referrer">
<meta name="theme-color" content="#455164">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well with the default theme, but how does it behave with other themes (this comment applies to colors within the manifest file too)?
My guess is that it's not as nice on other themes, at least for the theme-color setting, as the toolbar color would stay blue while the loaded theme is not.

Even when themes include metadata like a global color like this, it will be tricky: this needs to be re-set after the user logs in (assuming themes will be controlled by the user settings)

I'm OK with the background color, but could you double check with the toolbar color and see how it goes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's something that will be properly dealt with with actual theme packages. Then, we could template the manifest and have it work better. But for now I don't think there's much to do, and anything looks better than white at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're talking about the background color, I'm talking about the toolbar color.

It's not as bad as a website because when set up as an app, the URL + icons bar disappears, but this is not true for users that did not set up The Lounge as a standalone app (such as those testing the demo, or pretty much all public instances). Also applies to the very top bar, where time and battery/connectivity icons live, which is affected by the theme-color.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem as you are describing it, is that the color will look slightly out of place on non default themes. We can't really make this customizable per theme until we get packages or theme settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what about setting up only the background color and not the theme color until then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we left it in, there's no harm in it.

@astorije
Copy link
Member

Alright, I guess I can't win then :-)
👍 for now, hopefully this will get improved over time. I'll post some screenshots shortly (got to run now) to keep a ref somewhere when someone else decides to improve this.

@astorije astorije merged commit be8705b into master May 20, 2016
@astorije astorije deleted the xpaw/manifest branch May 20, 2016 23:26
@astorije
Copy link
Member

So, for the record, without this patch applied, we have:

First picture is in browser, others are "browser-less". Notice the black status bar (battery, connectivity, time, ...) across both modes.

Applying this patch, it works very nicely with the default theme:

Notice that the URL bar in the browser mode has changed, but so has the status bar in all modes. It is now a dark blue instead of black.

As a matter of fact, it works also very nicely on the Morning theme:

But... Not so much on Zenburn and Crypto themes:

I am using the default theme so I personally don't care too much, I know @xPaw is using Morning. Not worth reverting this at all, but good to keep in mind in case someone opens an issue for Zenburn or Crypto.

matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Add manifest.json for nicer mobile experience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants