-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload test results on appveyor builds #382
Conversation
That looks neat, 👍 |
It does look nice on AppVeyor, but for Travis CI, which I value more than AppVeyor, it looks to me that tests are not even run: https://travis-ci.org/thelounge/lounge/jobs/135370839#L706-L714. Also, new dev dependencies on developers' env while this is really useful only in AppVeyor, but that's the way it is with We could split paths between Travis CI and AppVeyor so that the reporters differ based on the CI but I think that would overcomplicate things for nothing, and therefore I'd be leaning towards another solution: be happy with the way it is right now. After all, I think it's not that bad. But if you have better to offer, I'm not close to ideas, as long as it doesn't mess up Travis CI and local |
f971ef0
to
e8dd83e
Compare
@astorije Good catch, I fixed it by moving |
236c478
to
0b6ea60
Compare
@xPaw, this won't work anymore because the I am giving it a try by specifying the reporter in a Note that I created a revert of your initial commit as a second commit before my attempt. Should you not like my solution, you can delete my 2 commits. Should you like it, you can delete yours and the revert :-) |
0b6ea60
to
e2f04fe
Compare
(Adding the |
e2f04fe
to
8addd5a
Compare
@astorije Brilliant solution! I've rebased the PR. |
@@ -13,6 +13,8 @@ environment: | |||
install: | |||
- ps: Install-Product node $env:nodejs_version | |||
- npm install | |||
- npm install mocha-appveyor-reporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I had put npm install mocha-appveyor-reporter
before npm install
on purpose. As it is right now, the reporter install happens after the npm run build
task and get lost/clogged up with the rest. Nicer to keep the installs together I think (but really no big deal!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think that matters.
…tests Upload test results on appveyor builds
Here's how it looks: https://ci.appveyor.com/project/astorije/lounge/build/61/tests