Supersede mkdirp with fs-extra #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
| @@ -52,7 +51,6 @@ ClientManager.prototype.loadUser = function(name) { | |||
|
|
|||
| ClientManager.prototype.getUsers = function() { | |||
| var users = []; | |||
| mkdirp.sync(Helper.USERS_PATH); | |||
There was a problem hiding this comment.
Since you removed these syncs from clientManager, can you add one in command-line/index.js after ensuring CONFIG_PATH folder?
| var Helper = require("../helper"); | ||
|
|
||
| program | ||
| .command("add <name>") | ||
| .description("Add a new user") | ||
| .action(function(name/* , password */) { | ||
| try { | ||
| mkdirp.sync(Helper.USERS_PATH); | ||
| fsextra.ensureDirSync(Helper.USERS_PATH); |
There was a problem hiding this comment.
This is ensured in index.js, so there's no need to do it again in the add command (remove the try/catch completely).
Ensure USERS_PATH exists at start. Remove unnecessary USER_PATH check. Use fs-extra's copy to write default config.
|
👍 |
|
Damn, this was merged before I had time to review (which is why I had assigned to myself), oh well. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Supersede mkdirp with fs-extra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #380.
Sorry about the duplicate pull requests.